Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update primary text color style to be foreground1 #1982

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

joannaquu
Copy link
Contributor

@joannaquu joannaquu commented Feb 29, 2024

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Update primary text color style to be foreground1

Binary change

Total increase: 3,920 bytes
Total decrease: -2,904 bytes

File Before After Delta
Total 30,908,368 bytes 30,909,384 bytes ⚠️ 1,016 bytes
Full breakdown
File Before After Delta
LabelTokenSet.o 56,504 bytes 60,288 bytes ⚠️ 3,784 bytes
__.SYMDEF 4,774,672 bytes 4,774,808 bytes ⚠️ 136 bytes
Label.o 134,104 bytes 131,200 bytes 🎉 -2,904 bytes

Verification

Visual Verification
Before After
before after

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@joannaquu joannaquu requested a review from a team as a code owner February 29, 2024 19:07
@joannaquu joannaquu merged commit a635921 into microsoft:main Mar 1, 2024
7 checks passed
@joannaquu joannaquu deleted the joannaqu/primary-label branch March 1, 2024 19:10
@mischreiber mischreiber mentioned this pull request Mar 6, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants