-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tab Bar View can hide separator and disable blur effect #2119
Merged
cbowdoin
merged 7 commits into
microsoft:main
from
cbowdoin:TabBarViewCanRemoveSeparator
Jan 22, 2025
Merged
Tab Bar View can hide separator and disable blur effect #2119
cbowdoin
merged 7 commits into
microsoft:main
from
cbowdoin:TabBarViewCanRemoveSeparator
Jan 22, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodes11
reviewed
Jan 17, 2025
joannaquu
reviewed
Jan 17, 2025
joannaquu
reviewed
Jan 17, 2025
A video demonstrating the updates to the demo controller should be added to the visual verification section. |
nodes11
approved these changes
Jan 22, 2025
Random thought - do we ever expect someone to toggle one of these but not both of these? If not, could encapsulate into single declarative property that effectively saws "are you detaching a tab bar from its child view controller"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Consumers have no way currently to control the separator and blur effect created by the tab bar view. This PR adds the ability to specify in the init that you want to disable either/both the separator or the blur effect. We do not apply any effect to the background view if the blur effect is disabled. If the separator is disabled we will set the hidden property on the separator view to true.
Tab Bar View demo app has the incrementor on the right and decrementor on the left to match LTR design patterns.
Additionally, it now has toggles for the control of the separator and blur effect.
Binary change
(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)
Verification
Visual Verification
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow