-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[macOS] Fix ObjC export of MultilinePillPickerView #2122
Merged
mischreiber
merged 8 commits into
microsoft:main
from
mischreiber:MultilinePillPickerView_objc
Jan 29, 2025
Merged
[macOS] Fix ObjC export of MultilinePillPickerView #2122
mischreiber
merged 8 commits into
microsoft:main
from
mischreiber:MultilinePillPickerView_objc
Jan 29, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lukas-cap
reviewed
Jan 28, 2025
Sources/FluentUI_macOS/Components/MultilinePillPicker/MultilinePillPickerView.swift
Outdated
Show resolved
Hide resolved
lukas-cap
approved these changes
Jan 28, 2025
nodes11
approved these changes
Jan 28, 2025
lukas-cap
reviewed
Jan 28, 2025
Sources/FluentUI_macOS/Components/MultilinePillPicker/MultilinePillPickerView.swift
Outdated
Show resolved
Hide resolved
Saadnajmi
approved these changes
Jan 29, 2025
lukas-cap
reviewed
Jan 29, 2025
lukas-cap
reviewed
Jan 29, 2025
Sources/FluentUI_macOS/Components/MultilinePillPicker/MultilinePillPickerView.swift
Outdated
Show resolved
Hide resolved
lukas-cap
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
My previous PR #2121 didn't work in ObjC as expected. Since we don't have a real ObjC demo in macOS yet, this was manually validated to quickly unblock the issue.
(The problem was inheriting from a generic class -- that silently fails to export to Objective-C, even though there's an
@objc
in the title.)Binary change
n/a, still can't measure macOS
Verification
Verified MPP component still renders as expected.
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow