Update to upload-artifact@v4

[joannaquu]

Platforms Impacted

• iOS
• visionOS
• macOS

Description of changes

v3 of actions/upload-artifact has been deprecated. Update to v4.

According to their migration documentation, none of the key differences between v3 and v4 should affect us.

• No multiple uploads to the same named Artifact
• No overwriting of Artifacts
• No merging of Artifacts
• No hidden files

Verification

Pending pipelines

Pull request checklist

This PR has considered:

• Light and Dark appearances
• iOS supported versions (all major versions greater than or equal current target deployment version)
• VoiceOver and Keyboard Accessibility
• Internationalization and Right to Left layouts
• Different resolutions (1x, 2x, 3x)
• Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
• iPad Pointer interaction
• SwiftUI consumption (validation or new demo scenarios needed)
• Objective-C exposure (provide it only if needed)

Microsoft Reviewers: Open in CodeFlow