Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show large content viewer instead of scaling pill buttons in large text mode #2127

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

laminesm
Copy link
Contributor

@laminesm laminesm commented Feb 6, 2025

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Currently, PillButtonBar is broken on large text mode and should be relying on its UILargeContentViewerInteraction instead. This change changes the font of the PillButton to not scale with size category changes and use a UILargeContentViewerInteraction.

Binary change

(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)

Verification

Pill buttons no longer scale and show a large content viewer instead.

Visual Verification
Before After
before after

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@laminesm laminesm requested a review from a team as a code owner February 6, 2025 22:37
@laminesm laminesm merged commit 8f6a3c0 into main Feb 6, 2025
7 checks passed
@laminesm laminesm deleted the laminemale/fix-pbb branch February 6, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants