Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(motion): handle reduced motion in createMotionComponent() #33353

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

layershifter
Copy link
Member

Previous Behavior

New Behavior

Related Issue(s)

  • Fixes #

Copy link

github-actions bot commented Nov 27, 2024

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-accordion
Accordion (including children components)
106.71 kB
32.714 kB
106.791 kB
32.742 kB
81 B
28 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
220.62 kB
63.913 kB
220.701 kB
63.944 kB
81 B
31 B
react-components
react-components: entire library
1.163 MB
291.211 kB
1.163 MB
291.258 kB
81 B
47 B
react-dialog
Dialog (including children components)
100.276 kB
30.064 kB
100.357 kB
30.096 kB
81 B
32 B
react-motion
@fluentui/react-motion - createMotionComponent()
4.293 kB
1.895 kB
4.378 kB
1.929 kB
85 B
34 B
react-motion
@fluentui/react-motion - createPresenceComponent()
5.024 kB
2.226 kB
5.103 kB
2.258 kB
79 B
32 B
react-toast
Toast (including Toaster)
98.326 kB
29.588 kB
98.407 kB
29.627 kB
81 B
39 B
react-tree
FlatTree
145.092 kB
41.692 kB
145.173 kB
41.732 kB
81 B
40 B
react-tree
PersonaFlatTree
145.78 kB
41.805 kB
145.861 kB
41.849 kB
81 B
44 B
react-tree
PersonaTree
142.011 kB
40.622 kB
142.092 kB
40.655 kB
81 B
33 B
react-tree
Tree
141.323 kB
40.519 kB
141.404 kB
40.542 kB
81 B
23 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
69.21 kB
20.174 kB
react-components
react-components: FluentProvider & webLightTheme
44.447 kB
14.59 kB
react-motion
@fluentui/react-motion - PresenceGroup
1.714 kB
819 B
react-portal-compat
PortalCompatProvider
8.39 kB
2.64 kB
react-timepicker-compat
TimePicker
107.39 kB
35.763 kB
🤖 This report was generated against 883151bfb7aa84ea8f950d2c27a806922d438122

Copy link

Pull request demo site: URL

@@ -6,5 +6,6 @@ import * as React from 'react';
export type MotionBehaviourType = 'skip' | 'default';
Copy link
Collaborator

@fabricteam fabricteam Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv9 Visual Regression Report

Avatar Converged 2 screenshots
Image Name Diff(in Pixels) Image Type
Avatar Converged.Badge Mask RTL.chromium.png 10 Changed
Avatar Converged.badgeMask.chromium.png 6 Changed
Drawer 1 screenshots
Image Name Diff(in Pixels) Image Type
Drawer.overlay drawer full.chromium.png 1155 Changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants