chore: fix web-components lint setup to avoid leaking rules to json parser scope #33852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
changed the title
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
fabricteam
reviewed
Feb 17, 2025
| @@ -1,14 +1,20 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentui-web-components-v3 Visual Regression Report
Avatar 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar. - Dark Mode.normal.chromium_1.png | 305 | Changed |
MenuList 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| MenuList. - Dark Mode.normal.chromium.png | 396 | Changed |
mainframev
approved these changes
Feb 18, 2025
|
|
Hotell
force-pushed
the
lint/fix-wc-setup
branch
from
af97725 to
0943911
Compare
… resolve json parsing issues
great catch @radium-v ! try now - it should be gone for good pls re-review @mainframev ty |
🕵 FluentUIV0 No visual regressions between this PR and main |
fabricteam
reviewed
Feb 19, 2025
| @@ -1,4 +1,12 @@ | |||
| // Default eslintrc for packages without one, or files outside a package | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
Drawer 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Drawer.overlay drawer full - High Contrast.chromium.png | 2231 | Changed |
fabricteam
reviewed
Feb 19, 2025
| @@ -1,4 +1,12 @@ | |||
| // Default eslintrc for packages without one, or files outside a package | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv8 Visual Regression Report
react-charting-AreaChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| react-charting-AreaChart.Custom Accessibility.default.chromium.png | 11 | Changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
wc doesn't follow recommended lint configuration guidelines. this ends up leaking rules execution within .json files and providing false positives
New Behavior
wc uses overrides for lint configuration which is future proof for flat config migrations and mitigates issues with leaking scopes from json parser.
Related Issue(s)