docs(react-color-picker): updated the spec and the migration #33918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-140
to
-141
| | step | `number` | 1 | Step for arrow navigation | | ||
| | customStep | `number` | 3 | Fast navigation | |
There was a problem hiding this comment.
Those are supported by default. And customStep idea was for faster navigation but because we use native inputs it's supported from the box.
Comment on lines
-147
to
-174
| Input fields with color values will be in `renderUtils`. It will contain default ColorPicker which has all colors represented and a preview swatch. This functionality is similar to V8. | ||
|
|
||
| ```tsx | ||
| import { ColorPicker } from '@fluentui/react-color-picker-preview'; | ||
|
|
||
| const COLOR = { h: 0, s: 1, v: 1 }; | ||
|
|
||
| export const Default = () => { | ||
| const [selectedColor, setSelectedColor] = React.useState(COLOR); | ||
| const handleChange: ColorPickerOnSelectEventHandler = (_, data) => { | ||
| setSelectedColor({ ...data.color, a: data.color.a ?? 1 }); | ||
| }; | ||
|
|
||
| return ( | ||
| <> | ||
| <ColorPicker color={color} onColorChange={handleChange}> | ||
| <ColorSlider /> | ||
| <AlphaSlider /> | ||
| <ColorArea /> | ||
| </ColorPicker> | ||
| <InputHexField color={color} onChange={handleChange} /> | ||
| <InputRgbField color={color} onChange={handleChange} /> | ||
| <ColorSwatch color={color}> | ||
| <div style={{ backgroundColor: `${selectedColor}` }} /> | ||
| </> | ||
| ); | ||
| }; | ||
| ``` |
There was a problem hiding this comment.
All the examples of inputs are in the storybook now
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
fabricteam
reviewed
Feb 27, 2025
| @@ -11,11 +11,11 @@ | |||
| #### Supported Props | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
Avatar Converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar Converged.badgeMask.normal.chromium.png | 5 | Changed |
| Avatar Converged.badgeMask - RTL.normal.chromium.png | 3 | Changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the spec and the migration docs