[WIP] fix: React 18 type issues in v8 #34345
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytrokirpa
commented
Apr 29, 2025
| @@ -2,7 +2,7 @@ import { concatStyleSets } from './concatStyleSets'; | |||
| import { extractStyleParts } from './extractStyleParts'; | |||
| import { IStyle } from './IStyle'; | |||
| import { IStyleOptions } from './IStyleOptions'; | |||
| import { IConcatenatedStyleSet, IProcessedStyleSet, IStyleSet } from './IStyleSet'; | |||
dmytrokirpa
commented
Apr 29, 2025
| return !!item && typeof item === 'object' && !!(item as React.ReactElement).type; | ||
| } | ||
|
|
||
| function _isCardItem(item: React.ReactNode): item is typeof CardItem { | ||
| function _isCardItem(item: unknown): item is typeof CardItem { |
There was a problem hiding this comment.
React.ReactNode is not assignable to typeof CardItem
dmytrokirpa
commented
Apr 29, 2025
| @@ -99,7 +99,7 @@ function _processStackChildren( | |||
| return childrenArray; | |||
| } | |||
|
|
|||
| function _isStackItem(item: React.ReactNode): item is typeof StackItem { | |||
| function _isStackItem(item: unknown): item is typeof StackItem { | |||
There was a problem hiding this comment.
the same as above
dmytrokirpa
force-pushed
the
fix/v8-type-issues
branch
from
bd750f9 to
4a692ad
Compare
dmytrokirpa
force-pushed
the
fix/v8-type-issues
branch
from
4a692ad to
2732a1c
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -2,7 +2,7 @@ import { concatStyleSets } from './concatStyleSets'; | |||
| import { extractStyleParts } from './extractStyleParts'; | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests/Callout 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/Callout.Gap space 25.default.chromium.png | 2181 | Changed |
| vr-tests/Callout.Rendering callout attached to a rectangle.default.chromium.png | 1832 | Changed |
| vr-tests/Callout.No callout width specified.default.chromium.png | 2126 | Changed |
| vr-tests/Callout.Top auto edge.default.chromium.png | 2196 | Changed |
vr-tests/Keytip 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/Keytip.Offset.default.chromium.png | 86 | Changed |
| vr-tests/Keytip.Root.default.chromium.png | 51 | Changed |
vr-tests/react-charting-AreaChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-AreaChart.Custom Accessibility.default.chromium.png | 11 | Changed |
vr-tests/react-charting-GaugeChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-GaugeChart.Basic.default.chromium.png | 2 | Changed |
vr-tests/react-charting-LineChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-LineChart.Multiple.default.chromium.png | 192 | Changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will get back to this when we migrate the monorepo to use React 18 types