Foundation: Promote Slots Implementation #7845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonGore
requested review from
kenotron,
dzearing,
kkjeer,
khmakoto and
natalieethell
|
Size Auditor did not detect a change in bundle size for any component! |
khmakoto
approved these changes
Jan 30, 2019
kkjeer
approved these changes
Jan 30, 2019
ecraig12345
reviewed
Jan 31, 2019
ecraig12345
approved these changes
Jan 31, 2019
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Promote Slots/Tokens Foundation implementation from experiments package into foundation package. This version completely replaces the old Foundation implementation that uses mergeStyleSets/classNames props, which would thoroughly break all components using it. However, all existing experiments components were already converted to use the new version of Foundation as part of #7552, and there are no OUFR components using Foundation.
The various PRs and rationale building up to these changes can be found linked to #7012.
Microsoft Reviewers: Open in CodeFlow