Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: Add a pod manifest for uvm test container #330

Draft
wants to merge 1 commit into
base: msft-main
Choose a base branch
from

Conversation

Ankita13-code
Copy link
Collaborator

Merge Checklist
  • Followed patch format from upstream recommendation: https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format
    • Included a single commit in a given PR - at least unless there are related commits and each makes sense as a change on its own.
  • Aware about the PR to be merged using "create a merge commit" rather than "squash and merge" (or similar)
  • The upstream/missing label (or upstream/not-needed) has been set on the PR.
Summary
Test Methodology

value: "4"
- name: TEST_MEMORY_EXPECTED_MEMORY_MB
value: "1982"
securityContext:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need to run privileged?

Copy link
Collaborator Author

@Ankita13-code Ankita13-code Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tested it manually, sudo was always needed. So I thought probably it would be required here as well.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's please clarify which test exactly requires this and only enable when needed. We will want this if we run this container on the host as a runc container so that we can e.g. detect if /dev/mshv is present

env:
- name: ENABLED_TESTS
value: "cpu,memory"
- name: TEST_CPU_EXPECTED_VCPU_COUNT

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't succeed without memory or cpu limits

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ms-mahuber What is meant by memory and cpu limits here? Is it something we need to set up explicitly while creating the VMs?

Copy link

@ms-mahuber ms-mahuber Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the pod manifest resources->limits->cpu|memory

value: "cpu,memory"
- name: TEST_CPU_EXPECTED_VCPU_COUNT
value: "4"
- name: TEST_MEMORY_EXPECTED_MEMORY_MB

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We internally also run this pod YAML against the vanilla handler where the observed memory values may diverge between kata and kata-cc - let's talk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants