-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples: Add a pod manifest for uvm test container #330
base: msft-main
Are you sure you want to change the base?
samples: Add a pod manifest for uvm test container #330
Conversation
Signed-off-by: Ankita Pareek <[email protected]>
value: "4" | ||
- name: TEST_MEMORY_EXPECTED_MEMORY_MB | ||
value: "1982" | ||
securityContext: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it need to run privileged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I tested it manually, sudo was always needed. So I thought probably it would be required here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's please clarify which test exactly requires this and only enable when needed. We will want this if we run this container on the host as a runc container so that we can e.g. detect if /dev/mshv is present
env: | ||
- name: ENABLED_TESTS | ||
value: "cpu,memory" | ||
- name: TEST_CPU_EXPECTED_VCPU_COUNT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't succeed without memory or cpu limits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ms-mahuber What is meant by memory and cpu limits here? Is it something we need to set up explicitly while creating the VMs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the pod manifest resources->limits->cpu|memory
value: "cpu,memory" | ||
- name: TEST_CPU_EXPECTED_VCPU_COUNT | ||
value: "4" | ||
- name: TEST_MEMORY_EXPECTED_MEMORY_MB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We internally also run this pod YAML against the vanilla handler where the observed memory values may diverge between kata and kata-cc - let's talk.
Merge Checklist
upstream/missing
label (orupstream/not-needed
) has been set on the PR.Summary
Test Methodology