Feat/token reuse #72
Merged
Feat/token reuse #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ndiritu
force-pushed
the
feat/token-reuse
branch
from
98511c5
to
4740ba6
Compare
Ndiritu
requested review from
ddyett,
MIchaelMainer,
zengin,
SilasKenneth and
shemogumbe
as code owners
|
baywet
reviewed
Feb 23, 2024
baywet
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to microsoftgraph/msgraph-sdk-php#1407
Developers have expressed an issue around
Passing their own tokens/previously retrieved tokens to the API client is helpful in delegated scenarios because it prevents them from forcing their customers to log in multiple times for each request. Design doc is available.
Changes in this PR:
InMemoryAccessTokenCacheto allow devs to hydrate it with access tokens & retrieve access tokens from it