New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add client options to the `ProviderFactory::create` #88

Merged

SilasKenneth merged 1 commit into dev from fix/allow-options

Jun 20, 2024

Member

SilasKenneth commented Jun 19, 2024 •

edited

Loading

This PR

Allows passing of client options to create factory method so users can easily use their custom client options i.e proxy and verify or just proxy.
Makes the $tokenServiceBaseUrl and $userInfoServiceBaseUrl optional and nullable so users can pass null if they want to keep the default value of microsoft graph or override it.

Related issue microsoftgraph/msgraph-sdk-php#1483


          Add client options to the ProviderFactory::create

56c83ba

SilasKenneth requested a review from a team as a code owner

June 19, 2024 12:04

sonarcloud bot commented Jun 19, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

baywet approved these changes

View reviewed changes

Ndiritu approved these changes

View reviewed changes

SilasKenneth merged commit 02c9e52 into dev

6 checks passed

SilasKenneth deleted the fix/allow-options branch

June 20, 2024 12:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet