Creating a plugin for DMesg log analysis post TC Execution #3637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
umfranci
commented
Feb 7, 2025
umfranci
commented
- The purpose of this Draft PR is to create a code for checking the DMesg logs for any exceptions once the test case execution is completed.
- The execution will be done based on a switch - the default value of which would be false - hence avoiding any unnecessary failures/noise.
- This can be later on extended to also check panic patterns or increase the scope of the checks executed after the test case is completed.
squirrelsc
reviewed
Feb 8, 2025
| @@ -501,6 +502,11 @@ def get_information(self) -> Dict[str, str]: | |||
|
|
|||
| return final_information | |||
|
|
|||
| def exec_check_dmesg_oops(self) -> bool: | |||
| return plugin_manager.hook.check_dmesg_oops( | |||
There was a problem hiding this comment.
- Group errors from different plugins, if it returns non-empty.
- Raise failure exception and let the upper layer to deal with it.
squirrelsc
reviewed
Feb 8, 2025
| @@ -1186,6 +1192,9 @@ class NodeHookSpec: | |||
| def get_node_information(self, node: Node) -> Dict[str, str]: | |||
| ... | |||
|
|
|||
| @hookspec | |||
There was a problem hiding this comment.
If it's only hooked in LISA upstream code, it doesn't need to use the hookspec. Just implement as a normal method.
squirrelsc
reviewed
Feb 8, 2025
| @@ -752,6 +752,16 @@ def start( | |||
| log=case_log, | |||
| ) | |||
|
|
|||
| nodes = environment.nodes | |||
There was a problem hiding this comment.
Move into __run_case after test passed, and let the handle_exception proceed the raised exception.
squirrelsc
reviewed
Feb 8, 2025
| @@ -1444,6 +1444,8 @@ class Platform(TypedSchema, ExtendableSchemaMixin): | |||
| capture_azure_information: bool = False | |||
| # capture boot time info or not | |||
| capture_boot_time: bool = False | |||
| # to check if dmesg logs need to be analyzed after each test case | |||
| check_dmesg_after_case: bool = False | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.