Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary sync #461

Merged
merged 1 commit into from
Feb 10, 2025
Merged

remove unnecessary sync #461

merged 1 commit into from
Feb 10, 2025

Conversation

Binyang2014
Copy link
Contributor

nop instruction is only for synchronization within the same threadblock. Cross threadblock synchronization is handled by barrier instruction. So insert nop only if the dependency is within the same threadblock.

@Binyang2014 Binyang2014 marked this pull request as ready for review February 8, 2025 08:42
@Binyang2014
Copy link
Contributor Author

Removed unnecessary nop instruction. MSCCLPPLang test fail is expected

@Binyang2014 Binyang2014 requested a review from Copilot February 8, 2025 08:43

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@Binyang2014 Binyang2014 merged commit a6e00cc into main Feb 10, 2025
12 of 14 checks passed
@Binyang2014 Binyang2014 deleted the binyli/remove-unnecessary-sync branch February 10, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants