Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FFA] Fixed an issue of symbol unresolved when enabling TPM #1102

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

kuqin12
Copy link
Contributor

@kuqin12 kuqin12 commented Jan 21, 2025

Description

The TpmServiceLib is not linkable when there is library class specified because its inf does not pertain the same logic of linking TpmServiceLib.

This change moved it to NULL library class so that it will be linked according to the build flag.

For details on how to complete these options and their meaning refer to CONTRIBUTING.md.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

This was tested buildable for QEMU SBSA.

Integration Instructions

N/A

@kuqin12 kuqin12 requested a review from Raymond-MS January 21, 2025 19:03
Copy link

@Raymond-MS Raymond-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing!

@kuqin12 kuqin12 added the type:bug Something isn't working label Jan 21, 2025
@kuqin12
Copy link
Contributor Author

kuqin12 commented Jan 21, 2025

Looks good. Thanks for fixing!

thanks for the review. sorry for the hassle :)

@kuqin12 kuqin12 merged commit 218ea72 into microsoft:feature/ffa_enablement Jan 21, 2025
10 checks passed
@kuqin12 kuqin12 deleted the fix_tpm branch January 21, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants