Fix source-generator bug with nonpublic constructors (#234)

microsoft · Mar 14, 2024 · 0a613e9 · 0a613e9
1 parent aa09f16
commit 0a613e9
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/NodeApi.Generator/ModuleGenerator.cs b/src/NodeApi.Generator/ModuleGenerator.cs
@@ -476,7 +476,8 @@ private void ExportType(
                     LambdaExpression adapter;
                     ConstructorInfo[] constructors = type.GetMembers()
                         .OfType<IMethodSymbol>()
-                        .Where((m) => m.MethodKind == MethodKind.Constructor)
+                        .Where((m) => m.MethodKind == MethodKind.Constructor &&
+                            m.DeclaredAccessibility == Accessibility.Public)
                         .Select((c) => c.AsConstructorInfo())
                         .ToArray();
                     if (constructors.Length == 1)
@@ -493,7 +494,9 @@ private void ExportType(
                     _callbackAdapters.Add(adapter.Name!, adapter);
                 }
                 else if (type.GetMembers().OfType<IMethodSymbol>().Any((m) =>
-                    m.MethodKind == MethodKind.Constructor && m.Parameters.Length == 0))
+                    m.MethodKind == MethodKind.Constructor &&
+                    m.DeclaredAccessibility == Accessibility.Public &&
+                    m.Parameters.Length == 0))
                 {
                     s += $"\t() => new {ns}.{type.Name}())";
                 }
@@ -741,7 +744,8 @@ public static string GetExportName(ISymbol symbol)
     private bool IsConstructorCallbackAdapterRequired(ITypeSymbol type)
     {
         IMethodSymbol[] constructors = type.GetMembers().OfType<IMethodSymbol>()
-            .Where((m) => m.MethodKind == MethodKind.Constructor)
+            .Where((m) => m.MethodKind == MethodKind.Constructor &&
+                m.DeclaredAccessibility == Accessibility.Public)
             .ToArray();
         if (constructors.Length > 1)
         {