Fix byte-array JSValue conversions #220
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #206
A .NET API that has a
byte[]
(in a property type, parameter type, or return type) should get projected as JSnumber[]
type, not a JSstring
type. This change removes the conversion operators betweenbyte[]
and string-typeJSValue
. Since code-generation for type conversions makes use of those operators, removing those conversions achieves the desired effect of keeping the array form of the type.In some scenarios it might actually be desirable to marshal .NET
byte[]
as JSstring
. So, it could be helpful then if there was a way for the application to control that behavior (related to #64). But I believenumber[]
is the most correct default.There were a few places in test code that were relying on the implicit conversion from
byte[]
toJSValue
; I replaced those with explicit conversions.