Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up CodeQL #241

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Set up CodeQL #241

merged 1 commit into from
Mar 21, 2024

Conversation

jasongin
Copy link
Member

@jasongin jasongin commented Mar 21, 2024

The default CodeQL workflow failed because Nerdbank.GitVersioning does not work with a shallow clone. This change adds a codeql.yml file to customize the build workflow. The main changes are to disable versioning and just build the .NET 8 target.

An update to the Nerdbank.GitVersioning package is required for support of the NBGV_GitEngine variable.

After each CodeQL run (weekly and on every PR), we should be able to see results on the (private) Security / Code scanning page of the repo.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@jasongin
Copy link
Member Author

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview.

The CodeQL workflow in the PR completed successfully. I can see there were some issues reported; I'll review those later.

@jasongin jasongin requested a review from vmoroz March 21, 2024 22:04
@jasongin jasongin merged commit f09753e into main Mar 21, 2024
24 checks passed
@jasongin jasongin deleted the dev/jasongin/codeql branch March 21, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants