Leak logger mutex #25134
Open
Leak logger mutex #25134
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snnn
reviewed
Jun 24, 2025
| static std::mutex& DefaultLoggerMutex() noexcept { | ||
| static std::mutex mutex; | ||
| static std::mutex* DefaultLoggerMutex() noexcept { | ||
| static std::mutex* mutex = new std::mutex(); |
There was a problem hiding this comment.
Define it as a global var would be fine.
Then there is no memory leak and no ordering issue.
There was a problem hiding this comment.
I just asked Gemini. Unfortunately, the destructor of std::mutex on macOS platform is not trivial. This is really sad!!!!!
There was a problem hiding this comment.
Could someone please help me confirm that? If we define std::mutex as a global var with default parameters:
std::mutext m;
Will its destructor call pthread_mutex_destroy ?
There was a problem hiding this comment.
It seems that Android has the same problem.
|
But, this PR will introduce memory leaks. We have a memory leak checker in the windows_x64_debug pipeline, and it failed because of that. Do we have to make this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allowing the destructor for
DefaultLoggerMutexto run may cause a crash on macOS in certain usages of ONNX Runtime (most notably, with theortRust bindings). Since the mutex is a static local variable, it's fine to just leak the memory.Motivation and Context
Resolves #24579, #25038.
This change was applied to the ONNX Runtime binaries that ship with
ortand no further issues have been reported.