fix(assertions): allow tuple as valid input type for expected text va…

…lues (#2723)
microsoft · Jan 27, 2025 · 4ecf61e · 4ecf61e
1 parent 9010889
commit 4ecf61e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/playwright/_impl/_assertions.py b/playwright/_impl/_assertions.py
@@ -874,7 +874,7 @@ def to_expected_text_values(
     ignoreCase: Optional[bool] = None,
 ) -> Sequence[ExpectedTextValue]:
     out: List[ExpectedTextValue] = []
-    assert isinstance(items, list)
+    assert isinstance(items, (list, tuple))
     for item in items:
         if isinstance(item, str):
             o = ExpectedTextValue(

diff --git a/tests/async/test_assertions.py b/tests/async/test_assertions.py
@@ -274,6 +274,10 @@ async def test_assertions_locator_to_have_text(page: Page, server: Server) -> No
     await expect(page.locator("div")).to_have_text(
         ["Text  1", re.compile(r"Text   \d+a")]
     )
+    # Should work with a tuple
+    await expect(page.locator("div")).to_have_text(
+        ("Text  1", re.compile(r"Text   \d+a"))
+    )
 
 
 @pytest.mark.parametrize(