Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dispatch touch events in webkit #34250

Merged
merged 2 commits into from
Jan 8, 2025
Merged

fix: dispatch touch events in webkit #34250

merged 2 commits into from
Jan 8, 2025

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Jan 8, 2025

Turns out WebKit has document.createTouch and createTouchList which can be used instead of new Touch().

Turns out WebKit has [document.createTouch](https://developer.mozilla.org/en-US/docs/Web/API/Document/createTouch) and
createTouchList which can be used instead of `new Touch()`.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Test results for "tests 1"

3 failed
❌ [installation tests] › tests/playwright-electron-should-work.spec.ts:21:5 › electron should work @package-installations-ubuntu-latest
❌ [installation tests] › tests/playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path @package-installations-ubuntu-latest
❌ [installation tests] › tests/playwright-electron-should-work.spec.ts:44:5 › should work when wrapped inside @playwright/test and trace is enabled @package-installations-ubuntu-latest

8 flaky ⚠️ [chromium-page] › tests/page/page-event-request.spec.ts:138:3 › should report navigation requests and responses handled by service worker with routing @chromium-ubuntu-22.04-node20
⚠️ [firefox-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [installation tests] › tests/playwright-component-testing.spec.ts:21:5 › pnpm: @playwright/experimental-ct-react should work @package-installations-macos-latest
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @ubuntu-20.04-chromium-tip-of-tree
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:146:3 › should remove cookies by name and domain @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsertype-connect.spec.ts:529:5 › launchServer › should save download @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:899:7 › cli codegen › should record omnibox navigations after performAction @webkit-ubuntu-22.04-node18

37477 passed, 644 skipped
✔️✔️✔️

Merge workflow run.

@yury-s yury-s merged commit edfbab2 into microsoft:main Jan 8, 2025
25 of 29 checks passed
@yury-s yury-s deleted the touch-wk branch January 8, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants