Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(svelte): add support for svelte5 #34715

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat(svelte): add support for svelte5 #34715

wants to merge 2 commits into from

Conversation

shfx
Copy link

@shfx shfx commented Feb 10, 2025

Adding support for svelte5.

This change works for us but I need some additional eyes and hands to verify if this is what you might need to upgrade to svelte5. Keep in mind this PR is using somewhat legacy api that is there just to help migration and should be rewritten to "native" before they ditch it (somewhere around svelte6)

Closes #30278

@shfx
Copy link
Author

shfx commented Feb 10, 2025

@microsoft-github-policy-service agree

This comment has been minimized.

Copy link
Contributor

Test results for "tests 1"

12 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:93:11 › should proxy local network requests › by default › localhost @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:93:11 › should proxy local network requests › by default › link-local @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › link-local @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:236:5 › selector generator › should use parent text @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/tracing.spec.ts:28:5 › should collect trace with resources, but no js @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-set-input-files.spec.ts:39:3 › should upload a folder @webkit-ubuntu-22.04-node18

37838 passed, 654 skipped
✔️✔️✔️

Merge workflow run.

@agg23
Copy link
Contributor

agg23 commented Feb 11, 2025

There's a lot of diff here because of auto-formatting. Please remove these changes.

@@ -18,6 +18,6 @@
"vite": "^5.2.8"
},
"dependencies": {
"svelte": "^4.2.8"
"svelte": "^5.19.9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we actually want to introduce ct-svelte4-vite to keep testing for vite4, wdyt @agg23

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll will try to do that today. Thanks for the input.

@shfx shfx marked this pull request as draft February 13, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: experimental-ct-svelte Svelte 5 support - svelte/internal won't be available
3 participants