-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(svelte): add support for svelte5 #34715
base: main
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree |
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"12 flaky37838 passed, 654 skipped Merge workflow run. |
There's a lot of diff here because of auto-formatting. Please remove these changes. |
@@ -18,6 +18,6 @@ | |||
"vite": "^5.2.8" | |||
}, | |||
"dependencies": { | |||
"svelte": "^4.2.8" | |||
"svelte": "^5.19.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we actually want to introduce ct-svelte4-vite to keep testing for vite4, wdyt @agg23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'll will try to do that today. Thanks for the input.
Adding support for svelte5.
This change works for us but I need some additional eyes and hands to verify if this is what you might need to upgrade to svelte5. Keep in mind this PR is using somewhat legacy api that is there just to help migration and should be rewritten to "native" before they ditch it (somewhere around svelte6)
Closes #30278