Fix StringUtils.ensureQuoted to escape multiple quotations (#382)

microsoft · Apr 5, 2024 · 6a2dcc8 · 6a2dcc8
1 parent a92d1f0
commit 6a2dcc8
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@microsoft/powerquery-parser",
-    "version": "0.15.9",
+    "version": "0.15.10",
     "description": "A parser for the Power Query/M formula language.",
     "author": "Microsoft",
     "license": "MIT",

diff --git a/src/powerquery-parser/common/stringUtils.ts b/src/powerquery-parser/common/stringUtils.ts
@@ -45,7 +45,7 @@ export function ensureQuoted(text: string): string {
         return text;
     }
 
-    return `"${text.includes(`"`) ? text.replace(`"`, `""`) : text}"`;
+    return `"${text.replace(/"/g, '""')}"`;
 }
 
 export function columnNumberFrom(text: string, requiredCodeUnit: number): number {

diff --git a/src/test/libraryTest/common/stringUtils.ts b/src/test/libraryTest/common/stringUtils.ts
@@ -13,6 +13,7 @@ describe("StringUtils", () => {
         it(`"`, () => expect(StringUtils.ensureQuoted(`"`)).to.equal(`""""`));
         it(`""`, () => expect(StringUtils.ensureQuoted(`""`)).to.equal(`""`));
         it(`"a"`, () => expect(StringUtils.ensureQuoted(`"a"`)).to.equal(`"a"`));
+        it(`a"b"c`, () => expect(StringUtils.ensureQuoted(`a"b"c`)).to.equal(`"a""b""c"`));
     });
 
     describe(`findQuote`, () => {