Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prompty: fix parsing of tool_calls when array in arguments #3820

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

ianchi
Copy link
Contributor

@ianchi ianchi commented Oct 19, 2024

Description

Current regex for parsing of tool_calls breaks if there is an array in the arguments (as it has a ']').
Consume up to end of block so it only matches the closing ']' and not any intermediate ones.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • I confirm that all new dependencies are compatible with the MIT license.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@luigiw
Copy link
Member

luigiw commented Oct 23, 2024

Hello @ianchi, thx for your PR. Do you have a GH issue that contains the specific error you run into? It will be nice if you can link the issue.

@ianchi
Copy link
Contributor Author

ianchi commented Oct 23, 2024

Hi @luigiw

This PR solves issue #3829

Added details on the error there.

Happy to share any other info that might help to solve this.

@ianchi
Copy link
Contributor Author

ianchi commented Oct 31, 2024

Hi @luigiw, any news on this?
When can we expect a fix?
Can I be of any help?
Sorry, but this is a real blocker for us.

@ianchi
Copy link
Contributor Author

ianchi commented Nov 8, 2024

Hi, any chance to advance with this?

@ianchi
Copy link
Contributor Author

ianchi commented Nov 16, 2024

Hi @luigiw, please can you comment on this?
It is a big blocker to adopt the library in our company, any chance to merge the fix?

Copy link

SDK CLI Global Config Test Result tool_calls

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 401ccad.

Copy link

Executor E2E Test Result tool_calls

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 401ccad.

Copy link

Executor Unit Test Result tool_calls

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 401ccad.

@luigiw luigiw merged commit 40c84b4 into microsoft:main Dec 2, 2024
37 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants