Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prompty: improve token count estimation #3821

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ianchi
Copy link
Contributor

@ianchi ianchi commented Oct 19, 2024

Description

Current token count estimation is incomplete.
This PR adds tools definitions and tool calls into the computation, and allows to define a valid OpenAI model name to use to determine the tokenizer, which is needed in case of Azure OpenAI when the deployment is not a valid OpenAI model name.

Fixes #3809.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • I confirm that all new dependencies are compatible with the MIT license.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Adds tools definitions and tool calls into the computation
This is needed for AzureOpenAI models where the deployment name is not a valid OpenAI model.
Copy link

github-actions bot commented Nov 2, 2024

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue/pull request label Nov 2, 2024
@ianchi
Copy link
Contributor Author

ianchi commented Nov 8, 2024

Hi, any chance to advance with this?

@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue/pull request label Nov 8, 2024
Copy link

SDK CLI Global Config Test Result tokens

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 9f047c7.

Copy link

Executor E2E Test Result tokens

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 9f047c7.

Copy link

Executor Unit Test Result tokens

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 9f047c7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Bad token estimation in Prompty
1 participant