-
Notifications
You must be signed in to change notification settings - Fork 121
show copilot instructions prompt at startup #2361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
); | ||
|
||
const buttons = [{ title: "Yes" }, { title: "No", isCloseAffordance: true }]; | ||
if (!userInvoked) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's user invoked, should we show a confirmation at all, or just update it? It's not like we're doing anything destructive, we only add content. If they explicitly invoked the command, prompting again might be excessive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe. My goal in showing the prompt was to help the user understand what they just clicked on. They may have been just poking around in the command palette - without this message, there's nothing telling them what actually happened, and I doubt most users would just know about copilot-instructions.md
.
{ title: "Yes" }, | ||
{ title: "No", isCloseAffordance: true }, | ||
"Add Q# guidance to copilot-instructions.md?\n\n" + | ||
"Updating this file will help GitHub Copilot understand and work better with Q# files and other Quantum Development Kit features.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should add a short-link here for more info. (e.g. aka.ms/qdk.copilot
). We can create that to point to the copilot wiki for now, and the official docs later.
I'm not merging this yet because I want to refine this a little to work better with VS Code Next's support for instructions file. For one, we should be able to drop our own |
|
||
// Also do a one-time prompt at startup | ||
if ( | ||
context.globalState.get<boolean>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might want to make this workspaceState
since the instructions files are workspace specific
Directly invoked by the user via "create Q# project" or "update Copilot instructions for Q#":
One-time prompt at startup: