-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ability to set app icons #1022
Conversation
75cfce9
to
5d51aff
Compare
tried to test it locally, and Android and iOS work fine - for some reason macos doesn't seem to work though (check icon in dock): I followed the repro steps + the ones from here for testing macos so I'm not sure if I'm doing something wrong? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after a bunch of local testing we figured out it was something with my local caching... it works fine now! Let's
### Platforms Impacted - [x] iOS - [x] macOS - [ ] win32 (Office) - [ ] windows - [x] android ### Description of changes Let's bump us to the latest release of react-native-test-app, which gets us a lot of goodies :) 1) Turbomodule support. microsoft/react-native-test-app#843 2) App icon support. microsoft/react-native-test-app#1022 3) iPad Slide Over window / multi-tasking support. microsoft/react-native-test-app#1032 We also got a designer to make us icons =). I chose the blue set over the pink set. ### Verification I didn't test building with turbo modules, we don't quite support this yet anyway. Verified that SlideOver windows work on iOS. Some additional JS fixes are needed to make layout act properly though. Android icon: ![Screen Shot 2022-08-03 at 11 54 53 AM](https://user-images.githubusercontent.com/6722175/182688353-ecc6d603-88de-42f6-8c4e-8141aecd0dc3.png) macOS icon (dock): ![image](https://user-images.githubusercontent.com/6722175/182688427-30fcd29a-2fe4-48b8-a720-96202a2e36e2.png) iOS icon ![Screen Shot 2022-08-03 at 10 45 12 AM](https://user-images.githubusercontent.com/6722175/182688298-3925cd20-eb9b-4d64-adb6-7dd74662b84d.png) ### Pull request checklist This PR has considered (when applicable): - [ ] Automated Tests - [ ] Documentation and examples - [ ] Keyboard Accessibility - [ ] Voiceover - [ ] Internationalization and Right-to-left Layouts
Description
Adds ability to set app icons.
iOS/macOS has the ability to set alternate icons. I've made affordances for it here, but will be implementing the actual support separately: #1023
Resolves #242.
Resolves #990.
Platforms affected
Test plan
Screenshots