Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macOS): Present the component immediately if there's only one #104

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jun 9, 2020

rnta-macos-start

@tido64 tido64 added the platform: macOS This affects macOS label Jun 9, 2020
@tido64 tido64 requested review from alloy and tom-un June 9, 2020 13:36
@tido64 tido64 self-assigned this Jun 9, 2020
Copy link
Member

@alloy alloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic all seems sound to me 👍 Comments are about doing things in a more Cocoa/consistent way.

macos/ReactTestApp/AppDelegate.swift Outdated Show resolved Hide resolved
macos/ReactTestApp/AppDelegate.swift Outdated Show resolved Hide resolved
@tido64 tido64 force-pushed the tido/macos-load-lone-component branch from 6f2df01 to e403cca Compare June 10, 2020 18:48
@tido64 tido64 force-pushed the tido/macos-load-lone-component branch from e403cca to 9438179 Compare June 10, 2020 19:10
@alloy alloy merged commit 3053831 into master Jun 11, 2020
@alloy alloy deleted the tido/macos-load-lone-component branch June 11, 2020 08:46
github-actions bot pushed a commit that referenced this pull request Jun 11, 2020
## [0.1.7](0.1.6...0.1.7) (2020-06-11)

### Bug Fixes

* **macOS:** Present the component immediately if there's only one ([#104](#104)) ([3053831](3053831))
@tido64
Copy link
Member Author

tido64 commented Jun 11, 2020

🎉 This PR is included in version 0.1.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: macOS This affects macOS released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants