[rush] Add --node-diagnostic-dir=DIR parameter #5099
Merged
+277
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmichon-msft
requested review from
iclanton,
octogonz,
apostolisms and
D4N14L
as code owners
D4N14L
approved these changes
Feb 7, 2025
libraries/rush-lib/src/logic/operations/NodeDiagnosticDirPlugin.ts
Outdated
Show resolved
Hide resolved
libraries/rush-lib/src/logic/operations/ShellOperationRunnerPlugin.ts
Outdated
Show resolved
Hide resolved
dmichon-msft
commented
Feb 7, 2025
libraries/rush-lib/src/logic/operations/ShellOperationRunnerPlugin.ts
Outdated
Show resolved
Hide resolved
dmichon-msft
force-pushed
the
cpu-profiler-plugin
branch
from
343e98b to
2d5024d
Compare
D4N14L
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new command line parameter
--node-diagnostic-dir=DIRthat, when specified, tells all child processes to write their NodeJS diagnostic output to${DIR}/${packageName}/${phaseIdentifier}so that information about package and phase is preserved without polluting the main tree.Details
Added a new phased command hook
createEnvironmentForOperationthat can be used to modify the environment variables that will be used for an Operation's execution. Note that this hook is executed duringcreateOperations, and so does not have access to any information that is produced after that point, e.g. the list of tracked files on the system.How it was tested
Local invocation with
NODE_OPTIONS=--heap-profand--node-diagnostic-dir=/workspaces/tempon my codespace produced a tree of .heapprofile files.Impacted documentation
CLI docs