Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net Agents - Fix and streamlining for OpenAIAssistantAgent #10583

Merged
merged 27 commits into from
Feb 19, 2025

Conversation

crickman
Copy link
Contributor

@crickman crickman commented Feb 18, 2025

Motivation and Context

Adjust design approach for OpenAIAssistantAgent to match that of AzureAIAgent, specifically around exposing the public constructor and not requiring the use of static factory methods. This approach enables all features present in the underlying SDK and addresses several initialization bugs based on the hidden/private constructor.

Obsolete methods are maintained for compatibility, but will not be graduated. Eventually, it is likely they will be removed.

Description

Changes:

  • Exposed public constructor for OpenAIAssistantAgent
  • Now support all assistant features (available in the SDK)
  • Deprecated factory methods and functional wrappers
  • Exposed extension methods to facilitate common operations
  • Adjusted all samples and tests
  • No single sample increased its line count...most have less lines of code

Fixes:

Contribution Checklist

@crickman crickman added bug Something isn't working experimental Associated with an experimental feature enhancement agents feature_graduation Applied to all feature graduation issues labels Feb 18, 2025
@crickman crickman self-assigned this Feb 18, 2025
@crickman crickman requested a review from a team as a code owner February 18, 2025 00:48
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Feb 18, 2025
@crickman crickman added this pull request to the merge queue Feb 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 19, 2025
@crickman crickman added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit e183399 Feb 19, 2025
19 checks passed
@crickman crickman deleted the agents-assistant-fixes-and-streamlining branch February 19, 2025 02:12
@crickman crickman added bug Something isn't working and removed bug Something isn't working kernel Issues or pull requests impacting the core kernel experimental Associated with an experimental feature labels Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agents bug Something isn't working enhancement feature_graduation Applied to all feature graduation issues .NET Issue or Pull requests regarding .NET code
Projects
Status: Sprint: Done
4 participants