Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net Agents - Refine call to MergeArguments #10629

Closed
wants to merge 6 commits into from
Closed

.Net Agents - Refine call to MergeArguments #10629

wants to merge 6 commits into from

Conversation

crickman
Copy link
Contributor

@crickman crickman commented Feb 20, 2025 •
edited
Loading

Motivation and Context

Consolidate logic to merge KernelArguments to where they arguments are consumed: FormatInstructions.

Ensures this step can't be skipped (one less implementation detail for each agent).

Contribution Checklist

@crickman crickman added .NET Issue or Pull requests regarding .NET code agents feature_graduation Applied to all feature graduation issues labels Feb 20, 2025
@crickman crickman self-assigned this Feb 20, 2025
@crickman crickman requested a review from a team as a code owner February 20, 2025 19:54
@github-actions github-actions bot changed the title .NET Agents - Refine call to MergeArguments .Net Agents - Refine call to MergeArguments Feb 20, 2025
@crickman crickman enabled auto-merge February 20, 2025 20:25
@crickman crickman added this pull request to the merge queue Feb 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 20, 2025
@crickman crickman added this pull request to the merge queue Feb 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 20, 2025
@crickman crickman added this pull request to the merge queue Feb 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 20, 2025
@crickman crickman enabled auto-merge February 20, 2025 21:27
@crickman crickman added this pull request to the merge queue Feb 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 20, 2025
@crickman crickman added this pull request to the merge queue Feb 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 20, 2025
@crickman crickman enabled auto-merge February 20, 2025 22:40
@crickman crickman added this pull request to the merge queue Feb 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 20, 2025
@crickman crickman closed this Feb 20, 2025
@crickman crickman added the wontfix This will not be worked on label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TaoChenOSU TaoChenOSU TaoChenOSU approved these changes

@eavanvalkenburg eavanvalkenburg eavanvalkenburg approved these changes

@alliscode alliscode alliscode approved these changes

@moonbox3 moonbox3 Awaiting requested review from moonbox3

Assignees

@crickman crickman

Labels
agents feature_graduation Applied to all feature graduation issues .NET Issue or Pull requests regarding .NET code wontfix This will not be worked on
Projects
Semantic Kernel
Status: Sprint: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crickman @TaoChenOSU @eavanvalkenburg @alliscode