Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Revert KernelAIFunction name separator using dash #10827

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stephentoub
Copy link
Member

Exploring fixing #10819. I'm interested in how CI reacts.

@RogerBarreto, any insights into why this previously changed from an underscore to a dash?

Thanks.

@stephentoub stephentoub requested a review from a team as a code owner March 6, 2025 03:08
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel kernel.core labels Mar 6, 2025
@github-actions github-actions bot changed the title Revert KernelAIFunction name separator using dash .Net: Revert KernelAIFunction name separator using dash Mar 6, 2025
@RogerBarreto
Copy link
Member

This was made on this PR

Running my Demo with FunctionCAlling wasn't working using the _, SemanticKernel creates by default - dashes instead of underscores.

@stephentoub
Copy link
Member Author

What wasn't working / how wasn't it working?

@RogerBarreto RogerBarreto self-assigned this Mar 11, 2025
@RogerBarreto
Copy link
Member

I have tried again and could not reproduce the problem, if it arises again I will reach out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel.core kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants