Small: Simplifying read_file/write_file for better encapsulation/cohesion #155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The read_file and write_file methods required the caller to pass an extension that was lower-case and included a leading period in order to determine whether the contents were parquet or csv. This design leaks expectations of the method to the caller (and relies on custom file path parsing to get the extension, which is usually not ideal.) It is also subject to potential errors where the caller passes the incorrect extension.
This revision simplifies the signature to take the file path and then all logic for determining how to read or write is encapsulated in the read_file/write_file methods.