Implement codefix for MSTEST0037: Use proper 'Assert' methods #4162
+735
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
reviewed
Nov 27, 2024
| @@ -354,10 +582,28 @@ public void MyTestMethod() | |||
| } | |||
| """; | |||
|
|
|||
| await VerifyCS.VerifyAnalyzerAsync( | |||
| // error CS1503: Argument 1: cannot convert from 'object' to 'bool' | |||
There was a problem hiding this comment.
Shall we instead not raise? We could detect if that can be converted to the other type. I guess
There was a problem hiding this comment.
The diagnostic is still correct IMO. It's that the codefix should be producing a cast.
| @@ -397,10 +646,28 @@ public void MyTestMethod() | |||
| } | |||
| """; | |||
|
|
|||
| await VerifyCS.VerifyAnalyzerAsync( | |||
| // error CS1503: Argument 1: cannot convert from 'object' to 'bool' | |||
There was a problem hiding this comment.
Same remark about avoiding the analyzer diagnostic instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3315