Only push output device messages to Test Explorer, don't push logs #4178
+83
−295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logs are intended to be used for diagnosing. They shouldn't be localized and they shouldn't be pushed to Test Explorer.
Youssef1313
commented
Nov 27, 2024
| @@ -40,7 +40,7 @@ public async Task DiscoverAndRun(string tfm) | |||
| await Task.WhenAll(discoveryListener.WaitCompletion(), runListener.WaitCompletion()); | |||
| Assert.AreEqual(1, discoveryCollector.TestNodeUpdates.Count(x => x.Node.NodeType == "action"), $"Wrong number of discovery"); | |||
| Assert.AreEqual(2, runCollector.TestNodeUpdates.Count, $"Wrong number of updates"); | |||
| Assert.IsFalse(logs.IsEmpty, $"Logs are empty"); | |||
| Assert.IsTrue(logs.IsEmpty, $"Logs are not empty"); | |||
There was a problem hiding this comment.
Need to carefully double check if this is expected. And if yes, it's ideal to have another test that shows logs being not empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs are intended to be used for diagnosing. They shouldn't be localized and they shouldn't be pushed to Test Explorer.