IDTReeS: remove support for plotting lidar point cloud #2428
+1
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjstewart
added
the
backwards-incompatible
github-actions
bot
added
documentation
|
I wonder how people would feel about also removing our dependency on |
|
We can also plot the 3D point cloud in matplotlib if this is a useful feature, PyVista is just overkill for our needs. |
adamjstewart
force-pushed
the
datasets/idtrees
branch
from
31a158f
to
794d756
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this feature (
IDTReeS.plot_las) is widely used and it requires multiple dependencies (pyvista,pyvista/setup-headless-display-action) just to test. Visualization has always been orthogonal to TorchGeo's goals. We would like the bare minimum plotting capable in matplotlib. Users can always use PyVista themselves outside of TorchGeo.