Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuroSAT: redistribute split files on Hugging Face #2432

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

EuroSAT: redistribute split files on Hugging Face #2432

wants to merge 2 commits into from
+34 −51

Conversation

adamjstewart
Copy link
Collaborator

@adamjstewart adamjstewart commented Nov 27, 2024 •
edited
Loading

Fixes #2424

Thanks @isaiahlg for reporting the issue and @tameTNT for finding a copy of the files!

Tested using:

from torchgeo.datasets import EuroSAT, EuroSATSpatial, EuroSAT100

EuroSAT('data/eurosat', download=True, checksum=True)
EuroSATSpatial('data/eurosatspatial', download=True, checksum=True)
EuroSAT100('data/eurosat100', download=True, checksum=True)

@adamjstewart adamjstewart added this to the 0.6.2 milestone Nov 27, 2024
@github-actions github-actions bot added datasets Geospatial or benchmark datasets testing Continuous integration testing labels Nov 27, 2024
@adamjstewart adamjstewart mentioned this pull request Nov 27, 2024
Open
adamjstewart
adamjstewart commented Nov 27, 2024
View reviewed changes
tests/datasets/test_eurosat.py
@@ -84,14 +60,14 @@ def test_add(self, dataset: EuroSAT) -> None:
assert len(ds) == 4

def test_already_downloaded(self, dataset: EuroSAT, tmp_path: Path) -> None:
EuroSAT(root=tmp_path, download=True)
type(dataset)(tmp_path)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing got a bit ugly. We don't actually have to test EuroSATSpatial or EuroSAT100, we could just test EuroSAT and get 100% coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
datasets Geospatial or benchmark datasets testing Continuous integration testing
Projects
None yet
Milestone
0.6.2
Development

Successfully merging this pull request may close these issues.

EuroSAT Dataset 403 Download Error
1 participant
@adamjstewart