GeoDatasets should use separate values for x and y resolution #2601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datasets
There was a problem hiding this comment.
Copilot reviewed 24 out of 38 changed files in this pull request and generated no comments.
Files not reviewed (14)
- torchgeo/datasets/eudem.py: Evaluated as low risk
- torchgeo/datasets/cms_mangrove_canopy.py: Evaluated as low risk
- torchgeo/datasets/astergdem.py: Evaluated as low risk
- torchgeo/datasets/enmap.py: Evaluated as low risk
- torchgeo/datasets/cdl.py: Evaluated as low risk
- torchgeo/datasets/agb_live_woody_density.py: Evaluated as low risk
- torchgeo/datasets/esri2020.py: Evaluated as low risk
- tests/datamodules/test_geo.py: Evaluated as low risk
- torchgeo/datasets/eurocrops.py: Evaluated as low risk
- tests/datasets/test_cbf.py: Evaluated as low risk
- tests/samplers/test_batch.py: Evaluated as low risk
- tests/samplers/test_single.py: Evaluated as low risk
- torchgeo/datasets/chesapeake.py: Evaluated as low risk
- tests/datasets/test_geo.py: Evaluated as low risk
| @@ -416,7 +416,7 @@ def __init__( | |||
| self, | |||
| paths: Path | Iterable[Path] = 'data', | |||
| crs: CRS | None = None, | |||
| res: float | None = None, | |||
| res: tuple[float, float] | None = None, | |||
There was a problem hiding this comment.
If possible, I would like all of these datasets to support both float and tuple[float, float] similar to how our Samplers work. We can use the same helper function to convert the former to the latter. This is also nice for backwards compatibility (which we have to start caring about soon).
There was a problem hiding this comment.
Also need to update docstrings to document the order of xres and yres.
|
The failing test is a bug present in our min version of rasterio (1.3.0.post1) in how it reads res from WarpedVRT. The minimum version that handles this correctly is 1.3.11.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors GeoDatasets to use separate values to store the x and y resolutions. This is pretty important because not all raster pixels are square.
Some notes:
sizein (height, width) format for the samplersCloses #2594