ObjectDetectionTask: support for non-RGB imagery (SAR, MSI, HSI) #2602
+13
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing
There was a problem hiding this comment.
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (1)
- requirements/min-reqs.old: Language not supported
Comments suppressed due to low confidence (2)
torchgeo/trainers/detection.py:210
- The new behavior introduced by adapt_input_conv should be covered by tests to ensure it works as expected.
weight = adapt_input_conv(in_channels, self.model.backbone.body.conv1.weight) # type: ignore[no-untyped-call]
tests/trainers/test_detection.py:30
- Verify that the removal of the 'ObjectDetectionTestModel' and related monkey patches does not leave any gaps in test coverage.
class ObjectDetectionTestModel(Module):
adamjstewart
changed the title
adamjstewart
force-pushed
the
trainers/detection
branch
from
5922fd1 to
7b9f02f
Compare
adamjstewart
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't yet have a non-RGB object detection dataset to test with, but I'm pretty sure this works. Needed to bump some deps and throw away some tests to get it to work.
Closes #1156