-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add reference resolver tests #561
Open
SoulPancake
wants to merge
8
commits into
microsoft:main
Choose a base branch
from
SoulPancake:ab/reference-resolver-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add reference resolver tests #561
SoulPancake
wants to merge
8
commits into
microsoft:main
from
SoulPancake:ab/reference-resolver-test
+178
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@microsoft-github-policy-service agree |
@jakebailey @KeoFoxy Thanks for adding the .idea folder to .gitignore |
jakebailey
reviewed
Mar 13, 2025
@rbuckton Any chance for the review yet? |
SoulPancake
commented
Mar 18, 2025
const identifier = "some-identifier" | ||
|
||
func TestNewReferenceResolver(t *testing.T) { | ||
t.Parallel() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can perhaps add a
//nolint:paralleltest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added some coverage for reference resolver in this
along with that I have added .idea dir to .gitignore as intelliJ Goland is incredibly common among Go developers.
Let me know your thoughts about this