Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix load stat for query result #18458

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

caohai
Copy link
Member

@caohai caohai commented Nov 26, 2024

For WebviewView, the load time should start with the resolveWebviewView call instead of with the controller initialization. The time from the latter approach can be artificially inflated as reactWebviewViewController instances are created during extension activation.
Before:
image

After:
image

Copy link

PR Changes

Category Main Branch PR Branch Difference
Code Coverage 49.73% 49.89% $${\color{lightgreen} .16\% }$$
VSIX Size 11713 KB 11704 KB $${\color{lightgreen} -9 KB \space (0\%) }$$
Webview Bundle Size 3108 KB 3092 KB $${\color{lightgreen} -16 KB \space (0\%) }$$

@caohai caohai merged commit e61b4d3 into main Nov 26, 2024
5 checks passed
@caohai caohai deleted the hacao/fix-query-result-load-stat branch November 26, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants