Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some inconsistencies in how we were building webviews, and brought everything into alignment:
context
, states are all namedstate
; before, we were mixing the names which led to some confusing code snippets where a variable namedstate
was not actually the state.context
is defined and returning if not.myVar!.something
if the type checker is unable to figure out that it's not null/undefined on its own. Usually, we should add checks to help the type checker along. Using a non-null assertion operator is a yellow flag that something may be wrong.provider
property in the context so that all the RPC functions for the webview are accessible directly.context
object. Happy to go either way, but we should keep consistent to make future work and debugging simpler. Any opinions?