Adding handling for expand node failures #18816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Changes
|
Benjin
requested review from
kburtram,
aasimkhan30,
cssuh,
caohai,
laurennat and
lewis-sanchez
as code owners
aasimkhan30
approved these changes
Feb 21, 2025
Benjin
added a commit
that referenced
this pull request
Feb 21, 2025
* Added handling for instance when failure to expand node * loc * Adding regression tests
kburtram
pushed a commit
that referenced
this pull request
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #18014
When connecting to a serverless database's master db, it connects immediately. If the underlying serverless db is paused, then expanding the database node can time out in STS, which sends a notification to MSSQL. Unsuccessful expansions were not being handled at all; this PR adds basic handling there.