Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: usage of deprecated version of Node.js #313

Closed
wants to merge 1 commit into from
Closed

fix: usage of deprecated version of Node.js #313

wants to merge 1 commit into from

Conversation

meghprkh
Copy link
Contributor

@meghprkh meghprkh commented Jul 30, 2024 •
edited
Loading

Fixes #308

@meghprkh meghprkh mentioned this pull request Jul 30, 2024
Merged
@karthiknadig karthiknadig self-assigned this Jul 30, 2024
@karthiknadig karthiknadig added the debt Technical debt or repo cleanup label Jul 30, 2024
@vscodenpa vscodenpa added this to the August 2024 milestone Jul 30, 2024
@meghprkh
Copy link
Contributor Author

meghprkh commented Jul 31, 2024 •
edited
Loading

The pull request here is to force-push and remove the conflicting commit 25fa7ec and merge #311 and #313 in order as both dont conflict.

@eleanorjboyd eleanorjboyd enabled auto-merge (squash) July 31, 2024 18:32
@eleanorjboyd
Copy link
Member

@karthiknadig any idea why this isn't able to merge?

@karthiknadig karthiknadig disabled auto-merge July 31, 2024 19:00
@karthiknadig karthiknadig reopened this Jul 31, 2024
@karthiknadig
Copy link
Member

@eleanorjboyd Yes. I need to remove this commit 25fa7ec

@karthiknadig
Copy link
Member

Due to org policy we can't force push to main. I will create a combined PR that takes commits from #311 and #313, and ensure that the contribution is correctly attributed in the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

@alexr00 alexr00 alexr00 approved these changes

@anthonykim1 anthonykim1 anthonykim1 approved these changes

@eleanorjboyd eleanorjboyd Awaiting requested review from eleanorjboyd

Assignees

@karthiknadig karthiknadig

Labels
debt Technical debt or repo cleanup
Projects
None yet
Milestone
August 2024
Development

Successfully merging this pull request may close these issues.

codeql-analysis.yml uses an action that uses a deprecated version of Node.js
7 participants
@meghprkh @eleanorjboyd @karthiknadig @alexr00 @anthonykim1 @vscodenpa @hamirmahal