Fix: Wait for clear command to execute before reusing terminal

[tcvdh]

clear command was in the middle of executing while the main (debugger) command started executing. Adding a small timeout to make sure the clear command executes before allowing the main command to be sent to the terminal.

this would happen when the settings.json has these settings:

{
  "debug.terminal.clearBeforeReusing": true,
  "terminal.integrated.focusAfterRun": "terminal",
}

Fixes #240953

[VACLAVHAVLIS]

V pohodě, jsem moc spokojen

[connor4312]

We should not just blindly add a delay. If shell integration is available (the common case) we should use TerminalShellIntegration.executeCommand and avoid having to delay.

[tcvdh]

@connor4312 if you check the lines above the pr code:

vscode/src/vs/workbench/api/node/extHostDebugService.ts

Lines 155 to 158 in a948ee5

	if (terminal.state.isInteractedWith && !terminal.shellIntegration) {
	terminal.sendText('\u0003'); // Ctrl+C for #106743. Not part of the same command for #107969
	await timeout(200); // mirroring https://github.com/microsoft/vscode/blob/c67ccc70ece5f472ec25464d3eeb874cfccee9f1/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts#L852-L857
	}

you can see after the ^C there is also a 200ms delay (which was related to an issue exactly the same as this, except about ^C being in the terminal command instead of clear). so i used the same fix/copied that for that on this issue.

for the clearBeforeReusing code, there isn't an if statement making sure that there is a terminal.shellIntegration (so we can't use it yet). so if you suggest using the shellIntegration for this instead of a delay, then where should there be an added if for the terminal.shellIntegration? and what if terminal.shellIntegration isn't true? should we then fall back to the delay? To me it makes more sense to copy the delay from the few lines above as it works always and doesn't depend on if terminal.shellIntegration is there or not.

if (terminal.shellIntegration) {
    terminal.shellIntegration.executeCommand('clear');
}

So what do you suppose is the best way to handle this? add an if statement like above to check if it is available? and if it isn't available fall back to the old solution with a delay?

(or add the if statement to the main if clearBeforeReusing statement, but this would only allow the setting clearBeforeReusing if the shellIntegration is also available, which isn't always the case)

[tcvdh]

@microsoft-github-policy-service agree

[tcvdh]

@connor4312 i have updated the PR code, i added the shellIntegration and kept the delay only for when the shellIntegration isn't available. Can you review my PR again to see if this is what you mean and are satisfied with this implementation?

[Tyriar]

lgtm