Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use utf8 as the output encoding #342

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Use utf8 as the output encoding #342

merged 1 commit into from
Sep 21, 2023

Conversation

calebkiage
Copy link
Contributor

@calebkiage calebkiage commented Sep 21, 2023 •
edited
Loading

Fixes #341

@calebkiage calebkiage requested a review from a team as a code owner September 21, 2023 07:41
andrueastman
andrueastman approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to do a version bump as well to make a release? Or will we do this later?

@calebkiage
Copy link
Contributor Author

I wanted to confirm that it fixes the issue. RC2 also should have the updated code.

@calebkiage calebkiage merged commit 387743b into main Sep 21, 2023
@calebkiage calebkiage deleted the fix/output-encoding branch September 21, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong encoding when piping/redirecting in shell
2 participants
@calebkiage @andrueastman