Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addressing https://github.com/mikelambert/react-native-fabric-crashly… #3

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

jondot
Copy link

@jondot jondot commented Jul 11, 2016

…tics/issues/1

@arronmabrey
Copy link

Here is a working link to the issue this PR addresses #1

@sibelius
Copy link

sibelius commented Feb 1, 2017

@mikelambert any progress on this?

@kyle-ssg
Copy link

kyle-ssg commented May 17, 2017

@jondot did you manage to get this working on android? If so what did you set --sourcemap-output to and what path did you look at with RNFS ? I notice that on android ${RNFS.MainBundlePath} is undefined

Other than that it works great on ios, huge improvement

@reyalpsirc
Copy link

@kyle-ssg Check if my pull request fits your needs.

@mikelambert
Copy link
Owner

Ugh I am guilty for leaving this lagging (if I'm reading #1 correctly). I am curious if @jondot and @reyalpsirc can coordinate to see if you both would prefer one approach versus the other. Or in the absence of agreement, a breakdown of the pros/cons of each approach would be nice.

I'm really sorry that I'm the lagging maintainer of this, given that I'm not really using this for stacktraces anymore, since moving to Sentry. If either of you are interested in becoming a committer for any future work, I'd be happy to hand it over, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants