Update from Milvus 2.3.0 to 2.3.10 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
commented
Feb 27, 2024
| @@ -25,19 +25,15 @@ public async Task Insert_Drop() | |||
| Assert.Equal(2, Assert.Single(result.Data)); | |||
|
|
|||
| mutationResult = await Collection.DeleteAsync("id in [2]"); | |||
| Assert.Collection(mutationResult.Ids.LongIds!, i => Assert.Equal(2, i)); | |||
| // Starting with Milvus 2.3.2, Delete no longer seems to return the deleted IDs | |||
| // Assert.Collection(mutationResult.Ids.LongIds!, i => Assert.Equal(2, i)); | |||
There was a problem hiding this comment.
@yhmo this specifically looks suspect; deleteCnt is correct on the MutationResult returned by the delete operation; but IDs is empty (though it used to be populated).
roji
force-pushed
the
2.3.10
branch
2 times, most recently
from
6cba2a0
to
ddbc986
Compare
weianweigan
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yhmo below are some changes that were needed when moving from 2.3.0 to 2.3.10 - can you confirm that these make sense?