Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: user-settings endpoint testing #24

Merged
merged 16 commits into from
May 20, 2022
Merged

Feature: user-settings endpoint testing #24

merged 16 commits into from
May 20, 2022

Conversation

akkbng
Copy link
Contributor

@akkbng akkbng commented May 16, 2022 •
edited
Loading

Added extended endpoint tests for the user settings routes --> close #16

For issue #19 --> I haven't figured the setup for the mock database, will put up a new PR for this.

@akkbng akkbng self-assigned this May 16, 2022
@akkbng akkbng added the enhancement New feature or request label May 16, 2022
This was linked to issues May 16, 2022
Add tests for user-settings routes #16
Closed
User-service: Add test_db config #19
Open
@akkbng akkbng removed a link to an issue May 20, 2022
User-service: Add test_db config #19
Open
@akkbng akkbng changed the title Feature: testing database Feature: user-settings endpoint testing May 20, 2022
@akkbng akkbng marked this pull request as ready for review May 20, 2022 18:41
@akkbng akkbng requested a review from isaschm May 20, 2022 18:41
isaschm
isaschm approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@isaschm isaschm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

user_service/routes/user_settings_routes.py Show resolved Hide resolved
@akkbng akkbng merged commit 4680aef into main May 20, 2022
@akkbng akkbng deleted the feature/testing_database branch May 20, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaschm isaschm isaschm approved these changes

Assignees

@akkbng akkbng

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests for user-settings routes
2 participants
@akkbng @isaschm